add support for gone links #48067
Merged
add support for gone links #48067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkarneges
force-pushed
the
jkarneges/disconnect-event
branch
from
aa94a17
to
c2b11ca
Compare
jkarneges
force-pushed
the
jkarneges/disconnect-event
branch
from
c2b11ca
to
22e251a
Compare
deg4uss3r
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a way to send notifications when HTTP subscribers disconnect. Backends can supply a
gonelink in a response header:When the client disconnects for any reason, Pushpin will make a
POSTrequest to the specified URL with an empty body. It will expect an empty response. The notification is best-effort: if the request fails for any reason, it will not be retried. It is also not guaranteed to occur, for example if Pushpin is shut down while clients are connected.